Gen-ART review comments for draft-ietf-keyprov-pskc-05: Protable Symmetric Key Container (PSKC) In general, good use of examples and the inclusion of the Appendices for use cases and requirements. Its not always obvious which elements are mandtory or optional, especially when optional elements may have mandatory child elements, however the examples and recommended values do help to clarify this somewhat. There are a few typos I've noted, also. Section 1: Introduction: "The document also specifies the information elements that are required when the symmetric key is utilized for specific purposes, such as the initial counter in the MAC-Based One Time Password (HOTP) [HOTP] algorithm. Should be: "... such as the intital counter in the "HOTP: An HMAC-Based One Time Password Algorithm" [HOTP] algorithm. I was searching for the term(HOPT) reference, and it appears [HOPT] reference names the spec as I've described. Section 3: Portable Key Container Entities Overview and Relationships Should be: "Portable Symmetric Key Container" Entity Overview and Relationships Are these entities all mandatory in the Container, or may some entities be optional? Figure 1: shows the high-level structure of the PSKC data elements Should be: .... PSKC entity elements. Its clear that the element is optional, however its not clear if all the child elements are mandatory if the Data element is present. Section 4.2 A PSKC document can contain a number of additional information regarding... Should be: "A PSKC document can contain a number of additional optional information elements regarding... " Clarify these elements are optional. Section 4.2.1: Element Its stated that "certain child elements of the element MUST be included in order to uniquely identify a device." Is there a set of device child elements that are common to all devices that are mandatory to included with the DeviceInfo element? This would be helpful. Section 4.2.2: Element: ": This element carries a unique identifier for the CryptoModule and is implementation specific. As such, it helps to identify a specific CryptoModule to which the key is being or was proivisioned. Typo in word "proivisioned". Also it would improve readability if the definition was worded as the one of the following.. "As such, it helps to identify a specific CryptoModule to which the key belongs or was provisioned." or "As such, it helps to identify a specific CryptoModule to which the key is being provisioned or was proivisioned to." Figure 4, 5 should have reference [HOPT] included in the Figure title. section: Good use of MUST in defining the registered token, I appreciate the clairity. I'm still a little confused on which elements are mandatory and optional. Would be a mandatory element? Section 9: Extensibility: Typo: "New XML Elements: The usage of the XML schema and the available extension points allows new XML elements to be added. Depending of type of XML elements different ways to "Depending on the type of XML elements..." Typo: "Policy: Section 5 defines policies that can be attached to a key and keying related data. The element is one such item that allows to restrict the use of the key to "... allows restricting the use of the key